Fix refcounting issues with new_event and its window.

2005-12-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
	issues with new_event and its window.

diff --git a/ChangeLog b/ChangeLog
index 8091dc9816f029c1d3fc2ea38497824e45d1d8df..5931b5ad2d89e88a5c52b37a321944196dea0e29 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2005-12-06  Matthias Clasen  <mclasen@redhat.com>
 
+       * gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
+       issues with new_event and its window.
+
        * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Accept NULL
        as a detach func.  (#323386, Jorn Baayen)
 

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 8091dc9816f029c1d3fc2ea38497824e45d1d8df..5931b5ad2d89e88a5c52b37a321944196dea0e29 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,5 +1,8 @@
 2005-12-06  Matthias Clasen  <mclasen@redhat.com>
 
+       * gtk/gtktreeview.c (gtk_tree_view_key_press): Fix refcounting
+       issues with new_event and its window.
+
        * gtk/gtkmenu.c (gtk_menu_attach_to_widget): Accept NULL
        as a detach func.  (#323386, Jorn Baayen)
 

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index 71cd603f0bd007442234b2fb03b29802d8961894..5a2f2d04f171fe45a23da13b218871a3569c05c5 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -4447,7 +4447,8 @@ gtk_tree_view_key_press (GtkWidget   *widget,
       /* Make a copy of the current text */
       old_text = g_strdup (gtk_entry_get_text (GTK_ENTRY (tree_view->priv->search_entry)));
       new_event = gdk_event_copy ((GdkEvent *) event);
-      ((GdkEventKey *) new_event)->window = tree_view->priv->search_entry->window;
+      g_object_unref (((GdkEventKey *) new_event)->window);
+      ((GdkEventKey *) new_event)->window = g_object_ref (tree_view->priv->search_entry->window);
       gtk_widget_realize (tree_view->priv->search_window);
 
       popup_menu_id = g_signal_connect (tree_view->priv->search_entry,